Hide values for row headers in Detailed Race and Ethnicity Section #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for labs-factfinder ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
horatiorosa
requested changes
May 10, 2024
|
@horatiorosa I looked into this pretty thoroughly and ultimately rolled back my changes as a sanity check. It looks like this test was failing before the changes introduced in this PR. Since it's out of scope for our issue, I think we should create another ticket for someone to rewrite this test to work, or remove the test. |
horatiorosa
approved these changes
May 17, 2024
|
@bmarchena Yep, gocha. I can confirm the test is flakey. I skipped the test and will fix the merge conflict via reverting a commit I made to staging afterwards I'll merge in your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic to hide values in current tables